The depot-finding code and wagon suggestion code included might be useful in some way. I hope that the code I've sent in proves useful in some way, even if just as inspiration or similar. As such, I think it best if I leave things be and move on at this point. It's been a few weeks now since I sent in the original code and I'm still not sure of a path to get this code into the main codebase, or if it is even useful or wanted. "Cheats" to reduce money are probably more helpful in testing than ones that increase it, especially in the context of "What happens if you can convert only some trains. I fear I'll need a fair bit more information- such as version, a savefile, how to reproduce- to have much of a chance of finding the problem. It is unlikely that I'll be able to find the error with just the assert line, given my limited understanding of the code thus far. Thanks for the link to the coding style document- I have been guessing the style for now, an official doc will help me clean it up. If I can recreate the problem, I might be able to fix it. Please feel free to send me details and/or savefiles directly if you like- my email address can be found in this image. Re assert failures, may I ask which version you applied from, what caused it, and where the assert failed? The patch removes two assertions, because they no longer hold true (one, for example, is a check that the train lengths match- something that isn't always true post-patch). not corresponding wagon) it will fail and not proceed on the DC_EXEC run? If I am incorrect- do you have a set of circumstances that cause it to fail, so I can make it fail here as well?Īny tips on changing money levels (up and down) to allow me to experiment with this as well? I should be able to figure it out, I'm just wondering if there is an easy way. I had thought that on a run without DC_EXEC with failure conditions (eg. The impression I got is that most operations are handled by a run without DC_EXEC first, and then a run with. :)īearing in mind that I am new to the OpenTTD codebase, I should point out that I'm not too strong on the function of DC_EXEC. it might be the middle of the night when I get your reply. I'm based in Australia, so please bear the different timezone in mind Get my changes included in the official code. When you can, please drop me an email and let me know what I need to do to I'm also happy to spend time cleaning up the code, adding additionalĬommenting, changing things as needed, and writing small bits of To do to clean it up for inclusion, et cetera. I'm now wondering what the best way is to get this code to you, what I need Getting this first bit in for now though. Tool to allow players to explicitly select conversions. List to convert the whole map, and integration with the vehicle upgrade Possible future additions would be to add a dropdown to the train manage Please bear in mind that I've only been using the sourceįor OpenTTD for a couple of days now, so it's still pretty new to me. It is also full of tracewrites at the moment, so I will need I've just keyed if off a single global variable at the moment. I also haven't figured out the patch system yet, so Service history and custom train names are not preserved (yet- could beĪdded in the future). Please note the code uses vehicle cloning rather than MaybeReplaceVehicleĪnd ReplaceVehicle (I tried, couldn't get it to work), so things such as The whole map while all trains are in their depots, *everything* is This means that if you drag the tool across Train inside and the depot to the new rail type, using the best-fit Using the rail conversion tool, select a depot. Using a best-fit selection of replacement locos and wagons. Select a depot with a new rail type, select "Clone Train", then a train With the changes I've made, there are two new things you can do: If you're one of the main devs, these are the sameĪs in the original email I sent you, nothing new here. The code is currently written against release r12366.įurther details follow. Know what needs fixing, help with an issue or two, and then integrate it I am looking to get in touch with someone who is able to look over theĬode (I've only been using the OpenTTD code for a couple of days), let me Groundwork for a mass-conversion tool between rail types (eg. Via the conversion tool for all trains in a depot. This can be done on a one-off basis for an individual train, or I have written code to allow trains to be automatically upgraded to a new
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |